Ensure valid wasms when publishing app #3206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibonacci1729
force-pushed
the
ensure-wasms
branch
from
e4c7bee to
76e466c
Compare
itowlson
approved these changes
Jul 22, 2025
Collaborator
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
The actual code that does the actual thing looks fine, but I did have a good old moan about the tests I'm afraid. Not a blocker but would be nice to tighten them up if you have the bandwidth.
fibonacci1729
force-pushed
the
ensure-wasms
branch
from
76e466c to
9b0a669
Compare
itowlson
approved these changes
Jul 22, 2025
Collaborator
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
Thanks, looks good! Just a couple of extremely non-blocking suggestions, feel free to ignore
Signed-off-by: Brian Hardock <[email protected]>
fibonacci1729
force-pushed
the
ensure-wasms
branch
from
9b0a669 to
2852d93
Compare
itowlson
reviewed
Jul 22, 2025
| macro_rules! make_locked { | ||
| ($source:literal, $($dep_name:literal=$dep_path:literal),*) => { | ||
| from_json!({ | ||
| "id": "jiggs", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that each
sourcefield and depenency source specified in a Spin component is a valid Wasm binary.